Add and announce local gas profiling via CLI and VM in Aptos.dev #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clay-aptos
commented
Mar 28, 2023
developer-docs-site/docs/cli-tools/aptos-cli-tool/use-aptos-cli.md
Outdated
Show resolved
Hide resolved
vgao1996
reviewed
Mar 28, 2023
developer-docs-site/docs/cli-tools/aptos-cli-tool/use-aptos-cli.md
Outdated
Show resolved
Hide resolved
developer-docs-site/docs/cli-tools/aptos-cli-tool/use-aptos-cli.md
Outdated
Show resolved
Hide resolved
gregnazario
approved these changes
Mar 28, 2023
|
|
||
| Run the gas profiler by appending the `--profile-gas` option to the aptos CLI `move publish`, `move run` or `move run-script` command, for example: | ||
| ```bash | ||
| cargo run -p aptos -- move publish --profile-gas |
There was a problem hiding this comment.
Let's change this to aptos move publish --profile-gas and I'll release a new version of the CLI tomorrow.
developer-docs-site/docs/cli-tools/aptos-cli-tool/use-aptos-cli.md
Outdated
Show resolved
Hide resolved
vgao1996
approved these changes
Mar 28, 2023
vgao1996
reviewed
Mar 28, 2023
developer-docs-site/docs/cli-tools/aptos-cli-tool/use-aptos-cli.md
Outdated
Show resolved
Hide resolved
vgao1996
approved these changes
Mar 28, 2023
| ### Debug and print stack trace | ||
| ### Profiling gas use | ||
|
|
||
| This *experimental* feature lets you [profile gas usage](https://github.com/aptos-labs/aptos-core/tree/main/aptos-move/aptos-gas-profiling) in the Aptos virtual machine locally rather than [simulating transactions](../../concepts/gas-txn-fee.md#estimating-the-gas-units-via-simulation) at the [fullnode](https://fullnode.devnet.aptoslabs.com/v1/spec#/operations/simulate_transaction). You may also use it to visualize the transaction gas log, in the form of a flame graph. |
There was a problem hiding this comment.
I feel like we don't necessarily have to mention the concept of the transaction gas log to the user as it is an internal implementation detail that is subject to change.
There was a problem hiding this comment.
Understood. I have removed references to the transaction log.
My pleasure! This is an excellent feature. :-D |
0xmaayan
approved these changes
Mar 30, 2023
saharct
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From:
#6535
Test Plan
Build and test locally